Bug 2034484: feat: bumped library-go#304
Bug 2034484: feat: bumped library-go#304openshift-merge-robot merged 4 commits intoopenshift:masterfrom
Conversation
|
|
||
| localv1 "github.com/openshift/local-storage-operator/api/v1" | ||
| "github.com/openshift/local-storage-operator/api/v1alpha1" | ||
| "github.com/prometheus/common/log" |
There was a problem hiding this comment.
I wasn't sure if there was a reason why the prometheus log package was pulled in, they recently did a refactor to a different package. Since we're already using klog and zap directly, figured it might be easier to utilize klog instead. Should I refactor to pull this in if needed?
There was a problem hiding this comment.
This change looks fine, I think it was a mistake that LSO ever used this prometheus log package.
updated library-go - update to use default leader election configs based off of cluster topology updated to k8s v0.23.0 updated controller-runtime to v0.11.0 to match k8s 23 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
fc56428 to
156007d
Compare
|
/assign @gnufied |
Signed-off-by: ehila <ehila@redhat.com>
|
I think https://github.com/openshift/local-storage-operator/pull/299/files PR also moves all logging in LSO to klog. cc @dobsonj |
|
/assign @dobsonj |
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@eggfoobar can you create a bugzilla for this? |
Signed-off-by: ehila <ehila@redhat.com>
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retitle Bug 2034484: feat: bumped library-go |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
bugzilla/severity-high
|
@eggfoobar: This pull request references Bugzilla bug 2034484, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
Bot
added
the
bugzilla/valid-bug
|
@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
@eggfoobar: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2034484 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.
Changes:
Signed-off-by: ehila ehila@redhat.com